fix(session): prevent dispatch args leaking as parent_id in select_session#356
Merged
sudo-tee merged 1 commit intosudo-tee:mainfrom Apr 12, 2026
Merged
Conversation
b45afc9 to
dea95be
Compare
Owner
|
Thanks for the fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After the commands refactor (#337), the dispatch layer calls all
executefunctions with the signatureexecute(args, range). Theselect_sessionkeymap alias was directly referencingM.actions.select_session, which interprets its first parameter asparent_id.When triggered via keymap with no arguments, dispatch passes
{}(empty args table) as the first argument. This causescore.select_sessionto filter sessions wheres.parentID == {}, which never matches — every session is filtered out, and the user always sees "No child sessions found".The
/sessionsslash command was unaffected because it routes through thesessioncommand handler, which callsM.actions.select_session()without arguments.Fix
Wrap the
executebinding so dispatch args are not forwarded asparent_id, matching the pattern already used byrename_sessionon the adjacent line.